Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tumblr): add support for content field #564

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

me4502
Copy link
Contributor

@me4502 me4502 commented Feb 3, 2025

This PR adds support for the Tumblr content field.

While for the default link type, the canonicalUrl is used, for other posttype values the content field is where actual data is entered.

I also added the rest of the posttype values from the Tumblr docs to the types (https://help.tumblr.com/knowledge-base/share-button-documentation/)

This was tested by manually editing the demo to type quote, and setting the value the quote as the content field, showing the following:
image

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: c1ff0b0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
react-share Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant