Cleanup some metrics #203
Merged
Cleanup some metrics #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `mem_fragmentation_ratio`: * Comes from `redis_memory_used_rss_bytes / redis_memory_used_bytes`. * Metric only provides 2 digits of accuracy compared to calculation. Add allocator metrics. Cleanup Prometheus naming of commands metrics names to avoid confusing references to being a "Summary" metric, it's not. Remove `total_system_memory`, this duplicates node_exporter metrics. Signed-off-by: Ben Kochie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 85.02% 85.02%
=======================================
Files 2 2
Lines 621 621
=======================================
Hits 528 528
Misses 67 67
Partials 26 26
Continue to review full report at Codecov.
|
|
Looks good, thank you! |
oliver006
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
mem_fragmentation_ratio:redis_memory_used_rss_bytes / redis_memory_used_bytes.Add allocator metrics.
Cleanup Prometheus naming of commands metrics names to avoid confusing
references to being a "Summary" metric, it's not.
Remove
total_system_memory, this duplicates node_exporter metrics.Signed-off-by: Ben Kochie [email protected]