Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retrieval of port. #255

Closed
wants to merge 1 commit into from
Closed

Fix retrieval of port. #255

wants to merge 1 commit into from

Conversation

ihrigb
Copy link
Contributor

@ihrigb ihrigb commented Apr 24, 2019

Addresses #247

@oliver006
Copy link
Owner

fyi, the tests failed

@oliver006
Copy link
Owner

Closing, this will be made obsolete by #256
Going forward all service discovery should happen within the Prometheus Server, all the cloudfoundry stuff will be removed from the exporter.

@oliver006 oliver006 closed this May 8, 2019
@ihrigb
Copy link
Contributor Author

ihrigb commented May 14, 2019

Sorry for not being responsive on this. I was busy with my wedding and then on honeymoon. Thanks for taking care of it.

@ihrigb ihrigb deleted the dev-port branch May 14, 2019 18:31
@oliver006
Copy link
Owner

No worries. Congrats on getting married!

@ihrigb
Copy link
Contributor Author

ihrigb commented May 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihrigb @oliver006