Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Wire up L2PayloadWitness hint for single-chain proof #1034

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Feb 13, 2025

Overview

Experimental wiring of the L2PayloadWitness hint, allowing op-reth to be used as the backing L2 execution client for kona-host.

@clabby clabby added K-feature Kind: feature A-binaries Area: binaries M-do-not-merge Meta: Do not merge labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Project coverage is 85.6%. Comparing base (b31d080) to head (a5e80cd).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/proof/mpt/src/noop.rs 0.0% 7 Missing ⚠️
bin/host/src/single/handler.rs 40.0% 3 Missing ⚠️
crates/proof/proof-interop/src/hint.rs 0.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review February 18, 2025 18:34
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codecov hurts me soul

wen monorepo we will need to be stricter about this...

@clabby clabby added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 587a79d Feb 19, 2025
15 of 16 checks passed
@clabby clabby deleted the cl/execution-witnes branch February 19, 2025 03:16
This was referenced Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-binaries Area: binaries K-feature Kind: feature M-do-not-merge Meta: Do not merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants