Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Kona Optimism Monorepo #1055

Merged
merged 1 commit into from
Feb 20, 2025
Merged

feat: Kona Optimism Monorepo #1055

merged 1 commit into from
Feb 20, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 19, 2025

Description

Migrates maili and hilo crates to kona, introducing kona as a monorepo as per https://op-rs.github.io/kona/rfc/monorepo.html

@refcell refcell added K-feature Kind: feature A-workspace Area: workspace level modifications labels Feb 19, 2025
@refcell refcell self-assigned this Feb 19, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.29835% with 333 lines in your changes missing coverage. Please review.

Project coverage is 92.5%. Comparing base (cf8aa2b) to head (57cfee8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/protocol/protocol/src/compression/shadow.rs 0.0% 53 Missing ⚠️
crates/protocol/protocol/src/batch/span.rs 98.4% 27 Missing ⚠️
crates/protocol/protocol/src/batch/single.rs 95.4% 21 Missing ⚠️
...rates/protocol/protocol/src/compression/variant.rs 59.5% 19 Missing ⚠️
...otocol/protocol/src/compression/brotli/compress.rs 80.2% 17 Missing ⚠️
crates/protocol/protocol/src/info/variant.rs 97.9% 16 Missing ⚠️
...tes/protocol/protocol/src/batch/tx_data/wrapper.rs 86.1% 15 Missing ⚠️
crates/protocol/protocol/src/fee.rs 95.8% 14 Missing ⚠️
crates/protocol/protocol/src/batch/bits.rs 90.9% 12 Missing ⚠️
crates/protocol/protocol/src/batch/transactions.rs 96.5% 11 Missing ⚠️
... and 33 more
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell marked this pull request as draft February 19, 2025 18:29
@refcell refcell force-pushed the monorepo branch 3 times, most recently from 641ad5e to 50f3625 Compare February 19, 2025 19:54
@refcell refcell marked this pull request as ready for review February 19, 2025 20:47
This was referenced Feb 19, 2025
Merged
Draft
@refcell @sebastianst
@Evalir @SkandaBhat @meyer9 @sergerad @fakedev9999 @klkvr @mattsse @merklefruit @clabby
feat: kona optimism monorepo
57cfee8 
chore: touchup labels

chore: touchup labels

chore: touchup labels

license label

fix: ci badge

fix: ci label

Co-Authored-By: Sebastian Stammler <[email protected]>
Co-Authored-By: evalir <[email protected]>
Co-Authored-By: Skanda Bhat <[email protected]>
Co-Authored-By: Julian Meyer <[email protected]>
Co-Authored-By: Serge Radinovich <[email protected]>
Co-Authored-By: fakedev9999 <[email protected]>
Co-Authored-By: Emilia Hane <[email protected]>
Co-Authored-By: Arsenii Kulikov <[email protected]>
Co-Authored-By: Matthias Seitz <[email protected]>
Co-Authored-By: nicolas <[email protected]>
Co-Authored-By: clabby <[email protected]>
clabby
clabby approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work. Added co-authors for all of the contributors to maili + hilo, so that their contributions live on. Let's get this in!

@clabby clabby enabled auto-merge February 20, 2025 01:43
@clabby clabby added this pull request to the merge queue Feb 20, 2025
@refcell
Copy link
Collaborator Author

refcell commented Feb 20, 2025

Amazing work. Added co-authors for all of the contributors to maili + hilo, so that their contributions live on. Let's get this in!

Good looks ty for that!!

Merged via the queue into main with commit 161547c Feb 20, 2025
18 checks passed
@clabby clabby deleted the monorepo branch February 20, 2025 02:10
This was referenced Feb 19, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@refcell refcell

Labels
A-workspace Area: workspace level modifications K-feature Kind: feature
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby