Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Maili Shadows #1071

Merged
merged 6 commits into from
Feb 21, 2025
Merged

fix: Maili Shadows #1071

merged 6 commits into from
Feb 21, 2025

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 20, 2025

Description

Fixes up maili shadow crates.

@refcell refcell added A-workspace Area: workspace level modifications K-chore Kind: chore labels Feb 20, 2025
@refcell refcell self-assigned this Feb 20, 2025
@refcell
Copy link
Collaborator Author

refcell commented Feb 20, 2025 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.5%. Comparing base (54f28c3) to head (fca7f30).
Report is 5 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell changed the title chore: Maili Shadows fix: Maili Shadows Feb 20, 2025
@refcell refcell mentioned this pull request Feb 21, 2025
Merged
clabby
clabby approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions to the interop crate.

@clabby clabby added this pull request to the merge queue Feb 21, 2025
mattsse
mattsse approved these changes Feb 21, 2025
View reviewed changes
crates/protocol/interop/Cargo.toml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw I added this

https://github.com/paradigmxyz/reth/blob/86e8a2a245490a1503c3c05c246f63f3d48e0175/Makefile#L383-L400

because I got tired of fixing toml fmt conflicts

Merged via the queue into main with commit 3baf40d Feb 21, 2025
18 checks passed
@clabby clabby deleted the rf/maili-shadows branch February 21, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@refcell refcell

Labels
A-workspace Area: workspace level modifications K-chore Kind: chore
Projects
Project Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@refcell @clabby @mattsse