Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(genesis): Rename HardForkConfiguration #1091

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Feb 22, 2025

Description

Been wanting to do this for a while.

We've been inconsistently naming configuration types across our codebase.
Some have the suffix "Configuration" while others have "Config".

This PR renames HardForkConfiguration type to HardForkConfig and
deprecated a new HardForkConfiguration alias to improve devx.

I don't see a need to spell out the full "configuration" blurb when most
everywhere just uses "config" to denote a configuration, but open to discussion.

@refcell refcell added the A-protocol Area: protocol crates label Feb 22, 2025
@refcell refcell requested a review from clabby as a code owner February 22, 2025 13:27
@refcell refcell added the K-chore Kind: chore label Feb 22, 2025
@refcell refcell requested a review from emhane as a code owner February 22, 2025 13:27
@refcell refcell self-assigned this Feb 22, 2025
@refcell
Copy link
Collaborator Author

refcell commented Feb 22, 2025

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (cd35822) to head (28d7727).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop the uration, it's cleaner

@mattsse
Copy link
Collaborator

mattsse commented Feb 22, 2025

fyi the failing deny job is likely paradigmxyz/reth#14650

@clabby clabby added this pull request to the merge queue Feb 24, 2025
Merged via the queue into main with commit e6facb3 Feb 24, 2025
18 checks passed
@clabby clabby deleted the chore/hardfork-config-rename branch February 24, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-protocol Area: protocol crates K-chore Kind: chore
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants