Replace anyhow with thiserror #1093
Open
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 23, 2025
Comment on lines
+22
to
+30
| #[derive(Debug, thiserror::Error)] | ||
| enum PreimageServerError { | ||
| #[error("Failed to serve preimage request: {0}")] | ||
| PreimageRequestFailed(PreimageOracleError), | ||
| #[error("Failed to route hint: {0}")] | ||
| RouteHintFailed(PreimageOracleError), | ||
| #[error("Join error: {0}")] | ||
| ExecutionError(#[from] tokio::task::JoinError), | ||
| } |
There was a problem hiding this comment.
this is used it pub api and should also be pub
a one-line doc also wouldn't hurt here
There was a problem hiding this comment.
Alright, I'll make these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a work in progress addressing #916.
I am aware that some of the changes in this PR introduce breaking changes in other parts of the workspace. I created this PR to take reviews on whether my approach looks good before proceeding further. Please let me know if these changes look good to you.