Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env var for filter #335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rafvasq
Copy link

@rafvasq rafvasq commented Feb 19, 2025

vllm-project#13225 will allow for passing regex in an environment variable VLLM_LOG_FILTER_PATTERNS. This PR sets the variable to redact guided decoding params by default.

cc: @joerunde

Signed-off-by: Rafael Vasquez <[email protected]>
Copy link

openshift-ci bot commented Feb 19, 2025

Hi @rafvasq. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtrifiro
Copy link

Is this meant to be added to Dockerfile.ubi and Dockerfile.rocm.ubi as well?

Signed-off-by: Rafael Vasquez <[email protected]>
@rafvasq
Copy link
Author

rafvasq commented Feb 20, 2025

@dtrifiro sorry, that's right. Was meant to be added to those two.

Copy link

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtrifiro, rafvasq

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 20, 2025

@rafvasq: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images e916e85 link true /test images
ci/prow/smoke-test e916e85 link true /test smoke-test
ci/prow/cuda-pr-image-mirror e916e85 link true /test cuda-pr-image-mirror

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

groenenboomj pushed a commit that referenced this pull request Feb 24, 2025
* Using tensors in the explicit cache function calls from mllama implementation

* Properly creating the tensor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants