feat(encryption): add rest api translations #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Abhinandan-Purkait
commented
Feb 20, 2025
Abhinandan-Purkait
commented
- Add openapi changes
tiagolobocastro
approved these changes
Feb 20, 2025
| "".to_string(), | ||
| ))? | ||
| .into(); | ||
| Ok(Self { cipher, key }) |
There was a problem hiding this comment.
Shall we validate the encryption key vector and len match?
There was a problem hiding this comment.
I think it's done in data-plane. But yes we can do that.
| key_name: | ||
| description: |- | ||
| Name of the key. | ||
| type: string |
There was a problem hiding this comment.
Should we add max name len?
There was a problem hiding this comment.
We can probably? Should I?
There was a problem hiding this comment.
Could you lint the openapi file as a separate commit? Example: bdd6649
|
|
Abhinandan-Purkait
force-pushed
the
encr_rest
branch
2 times, most recently
from
f13a05f to
236342f
Compare
Abhinandan-Purkait
force-pushed
the
encr_rest
branch
from
236342f to
bc0b4fc
Compare
Signed-off-by: Abhinandan Purkait <[email protected]>
Abhinandan-Purkait
force-pushed
the
encr_rest
branch
from
bc0b4fc to
e81f3cb
Compare
Signed-off-by: Abhinandan Purkait <[email protected]>
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.