feat: support stripe webhooks for payment statuses #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
5 times, most recently
from
40afb42 to
4157137
Compare
turip
changed the base branch from
main
to
feature/om-1162-support-payment-states-with-sandbox-app
turip
force-pushed
the
feature/om-1162-support-payment-states-with-sandbox-app
branch
from
c9ab650 to
2957794
Compare
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
3 times, most recently
from
a154459 to
b5dbad3
Compare
turip
force-pushed
the
feature/om-1162-support-payment-states-with-sandbox-app
branch
from
2957794 to
1301954
Compare
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
from
b5dbad3 to
12d8d32
Compare
turip
force-pushed
the
feature/om-1162-support-payment-states-with-sandbox-app
branch
from
1301954 to
b382132
Compare
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
2 times, most recently
from
0c53713 to
b177ffc
Compare
turip
force-pushed
the
feature/om-1162-support-payment-states-with-sandbox-app
branch
from
e485095 to
124e212
Compare
Base automatically changed from
feature/om-1162-support-payment-states-with-sandbox-app
to
main
February 3, 2025 11:53
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
2 times, most recently
from
9d17712 to
220337d
Compare
This patch adds support for receiving payment status updates from stripe including the void state. The docs folder contains more details on validating and setup.
turip
force-pushed
the
feature/om-1114-store-payment-status-on-invoice
branch
from
220337d to
667b205
Compare
turip
changed the title
turip
added
release-note/feature
hekike
approved these changes
Feb 3, 2025
| return nil, err | ||
| } | ||
|
|
||
| if len(invoices.Items) == 0 { |
There was a problem hiding this comment.
shouldn't we return NotFound and handle it upstream? Like we do with DB
There was a problem hiding this comment.
I want to ignore any invoices that we don't know of. E.g. if there are invoices generated on the stripe side, let's ignore them for now.
| query = query.Where(billinginvoice.PaymentAppExternalIDIn(input.ExternalIDs.IDs...)) | ||
| case billing.TaxExternalIDType: | ||
| query = query.Where(billinginvoice.TaxAppExternalIDIn(input.ExternalIDs.IDs...)) | ||
| } |
There was a problem hiding this comment.
It's not needed as it's part of the validation:
openmeter/openmeter/billing/invoice.go
Line 641 in 667b205
| @@ -0,0 +1,81 @@ | |||
| # Developing against a stripe test account | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This patch adds support for receiving payment status updates from stripe including the void state.
The docs folder contains more details on validating and local setup.