Upgrade to Astro v5 and preact #1153
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
lukewarlow
commented
Feb 7, 2025
| @@ -6,7 +6,8 @@ const CONTRIBUTORS = []; | |||
| const fetchContributors = async (page) => { | |||
| const response = await fetch(`${CONTRIBUTORS_URL}?page=${page}`); | |||
| const contributors = await response.json(); | |||
| CONTRIBUTORS.push(...contributors); | |||
| if (Array.isArray(contributors)) | |||
There was a problem hiding this comment.
The home page crashes locally pretty quickly without this check, as GitHub API has rate limits.
lukewarlow
force-pushed
the
upgrade-astro5
branch
from
58a2397 to
4b8013a
Compare
|
I think this will need the netfliy nodejs version upgraded. |
This happens to improve the prefetch behaviour so that it only happens on link hover instead of on page load.
This reduces the size of the JS bundles.
lukewarlow
force-pushed
the
upgrade-astro5
branch
from
1ef8f50 to
cde89e3
Compare
lukewarlow
commented
Feb 23, 2025
| import { useStore } from '@nanostores/react' | ||
| import React from 'react' | ||
| import { isMenuOpen } from '../../state/menuState' | ||
| import { useSignal } from '@preact/signals' |
There was a problem hiding this comment.
Should probably just swap this for a useState no need to bring in signals just for this.
lukewarlow
commented
Feb 23, 2025
| navRef.current.removeEventListener('command', handleCommand) | ||
| } | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
This needs an empty array as the second param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens to improve the prefetch behaviour so that it only happens on link hover instead of on page load.