StreamerBase: add write tokens vector #1769
Open
+470
−295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: LLM
as-suvorov
changed the title
as-suvorov
requested review from
Wovchena,
ilya-lavrenov,
pavel-esir and
apaniukov
and removed request for
Wovchena
sbalandi
reviewed
Feb 19, 2025
| """ | ||
| Write is called every time new token is decoded. Returns a StreamingStatus flag to indicate whether generation should be stopped or cancelled | ||
| Put is called every time new token or vector of tokens is decoded. Returns a bool flag to indicate whether generation should be stopped, if return true generation stops |
There was a problem hiding this comment.
It was copypasted, thanks, fixed
Wovchena
requested changes
Feb 20, 2025
Wovchena
approved these changes
Feb 21, 2025
| public: | ||
| StreamingStatus write(int64_t token) override; | ||
| StreamingStatus write(const std::vector<int64_t>& tokens) override; |
There was a problem hiding this comment.
FYI @mzegla
as you requested such method
There was a problem hiding this comment.
Yes, that should remove the need for our WA for streaming the prompt back. Thanks.
ilya-lavrenov
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamingStatus write(const std::vector<int64_t>& tokens)forStreamerBaseStreamingStatus write(const std::vector<int64_t>& tokens)forTextStreamerStreamerBaseinterface & deprecatesChunkStreamerBaseinterface