Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setfullsubject #1370

Closed
mstarks01 opened this issue Mar 3, 2018 · 7 comments
Closed

setfullsubject #1370

mstarks01 opened this issue Mar 3, 2018 · 7 comments
Labels
bug

Comments

@mstarks01
Copy link
Contributor

setfullsubject=0, which makes subject lines more compact, seems to no longer work.

It used to be that I could just do this:

#cd src; make setfullsubject #cd ..; ./install.sh

but the Makefile changed. So, I went in and set CLEANFULL?=yes, recompiled, and subsequently set maild.full_subject=0 in etc/local_internal_options.conf.

I'm still getting longer subject lines.
@mstarks01 mstarks01 added the bug label Mar 3, 2018
@ddpbsd
Copy link
Member

ddpbsd commented Mar 5, 2018

I didn't even know this was a feature.
Compiling with:

 gmake TARGET=server CLEANFULL=y

and setting this in internal_options.conf:

maild.full_subject=1

gives me this:

2 - Unknown problem somewhere in the system. - (rossak) 192.168.18.204

Is that what you're hoping for? When was the last time it worked how you expected?

@mstarks01
Copy link
Contributor Author

It has been awhile since I have used OSSEC in production. Maybe 2.8.3? Look at step 5 here to see how it is supposed to work.

@mstarks01
Copy link
Contributor Author

I downgraded to 2.8.3 and it works correctly in that version, so this appears to be a regression.

@ddpbsd
Copy link
Member

ddpbsd commented Mar 11, 2018

Tracking it down now. I'm not entirely sure how interested I am in when it was changed and why, but I'm expecting to have a fix shortly.

@mstarks01
Copy link
Contributor Author

I'm going to do some more digging as well. I don't want you to spend too much time on this in case I configured the new makefile incorrectly or just forgot a step. :)

@ddpbsd
Copy link
Member

ddpbsd commented Mar 11, 2018

I think the smaller subject may become the default post-3.0.

ddpbsd added a commit to ddpbsd/ossec-hids that referenced this issue Mar 11, 2018
@ddpbsd
Fix the subject handling. Issue submitted by Michael Starks ossec#1370
f4cf191 
If CLEANFULL is enabled during the build, and maild.full_subject=0
the email subjects should be smaller. At some point the logic may
have been reversed (or the documentation and memories of users are
backwards).
Either way, allow this to work the way it's understood to work.
@ddpbsd
Copy link
Member

ddpbsd commented Mar 11, 2018

Pull request #1377 allows this to work the way it used to.

atomicturtle added a commit that referenced this issue Mar 15, 2018
@atomicturtle
Merge pull request #1377 from ddpbsd/issue_1370_mail_subject
a736665 
Fix the subject handling. Issue submitted by Michael Starks #1370
ddpbsd added a commit to ddpbsd/ossec-hids that referenced this issue Sep 10, 2018
@ddpbsd
Remove the subject selection options. It feels like it should be simple,
a3c83bb 
but no one can agree on if it's working or not. So let's just get rid
of it. I chose the short subject option as the default.
References: Issue ossec#1370, Pull Request: 1377
@ddpbsd ddpbsd mentioned this issue Sep 10, 2018
Open
@ddpbsd ddpbsd closed this as completed Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstarks01 @ddpbsd