Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more appropriate names for forkchoice subscriptions #10393

Closed
mattsse opened this issue Aug 20, 2024 · 0 comments · Fixed by #10401
Closed

Use more appropriate names for forkchoice subscriptions #10393

mattsse opened this issue Aug 20, 2024 · 0 comments · Fixed by #10401
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 20, 2024

Describe the feature

this should be named subscribe_safe_block

/// Convenience method to get a stream of the new safe blocks of the chain.
fn fork_choice_stream(&self) -> ForkChoiceStream {
ForkChoiceStream { st: WatchStream::new(self.subscribe_to_safe_block().0) }
}

we also want a function for finalized

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Aug 20, 2024
@mattsse mattsse removed the S-needs-triage This issue needs to be labelled label Aug 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants