Use more appropriate names for forkchoice subscriptions #10401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenpaff
commented
Aug 20, 2024
| } | ||
|
|
||
| /// Convenience method to get a stream of the new finalized blocks of the chain. | ||
| fn finalized_block_stream(&self) -> ForkChoiceStream { |
There was a problem hiding this comment.
we also want a function for finalized
@mattsse did I understand it correctly, new function to return a stream of finalized blocks?
jenpaff
requested review from
rakita,
joshieDo,
shekhirin,
fgimenez,
mattsse and
rkrasiuk
as code owners
fgimenez
approved these changes
Aug 21, 2024
mattsse
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10393