Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define OpTransactionSigned #11575

Closed
Tracked by #7649
emhane opened this issue Oct 8, 2024 · 2 comments · Fixed by #11433
Closed
Tracked by #7649

Define OpTransactionSigned #11575

emhane opened this issue Oct 8, 2024 · 2 comments · Fixed by #11433
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code

Comments

@emhane
Copy link
Member

emhane commented Oct 8, 2024

Describe the feature

Define type that ports optimism feature gated behaviour, in TransactionSigned impl, into impl of new reth trait for signed transaction. Ref #11253.

Additional context

No response
@emhane emhane added C-debt A clean up/refactor of existing code A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library labels Oct 8, 2024
This was referenced Oct 8, 2024
Merged
Closed
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 30, 2024
@emhane emhane removed the S-stale This issue/PR is stale and will close with no further activity label Oct 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open for 21 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Nov 21, 2024
@emhane emhane removed the S-stale This issue/PR is stale and will close with no further activity label Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(sdk): define OpTransactionSigned paradigmxyz/reth
1 participant
@emhane