-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): define OpTransactionSigned
#11433
Conversation
if you stack prs, please reference them, otherwise this makes it harder to navigate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before we do anything her let's please try to make progress on some abstractions first (#11432)
and validate this against our current primitives types before we introduce new ones.
this is more efficient than working on separate network specific types already.
gottcha. this is code is checked out from #11348 (referenced in commit message). it moves the logic in |
cf72724
to
00f899f
Compare
2d15914
to
b4121c2
Compare
…e with TransactionSigned
c81bca9
to
8aa1aef
Compare
…th new TransactionSigned
Closes #11575
OpTransactionSigned
, that wrapsreth_optimism_primitives::OpTransaction
optimism
feature gated logic fromTransactionSigned
impl, intoimpl SignedTransaction for OpTransactionSigned