tx-pool: rm constraint for PoolTransaction
#10024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Aug 2, 2024
Comment on lines
+771
to
+772
| /// Define a method to convert from the `Pooled` type to `Self` | ||
| fn from_pooled(pooled: Self::Pooled) -> Self; |
There was a problem hiding this comment.
I think this is also a temporary, thing, because there can be a usecase where this conversion requires additional context, but this is a good solution for now
| @@ -31,7 +31,7 @@ pub trait TransactionOrdering: Send + Sync + 'static { | |||
| type PriorityValue: Ord + Clone + Default + fmt::Debug + Send + Sync; | |||
|
|
|||
| /// The transaction type to determine the priority of. | |||
| type Transaction: PoolTransaction; | |||
| type Transaction: PoolTransaction<Pooled = PooledTransactionsElementEcRecovered>; | |||
There was a problem hiding this comment.
cool, this has the same effect but makes it easier to make progress, nice
There was a problem hiding this comment.
yes seems nice for now for both the comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8668
cc @mattsse one more step