Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: CanonChainTracker implementation for BlockchainProvider2 #10378

Merged
merged 3 commits into from
Aug 22, 2024
Merged

test: CanonChainTracker implementation for BlockchainProvider2 #10378

merged 3 commits into from
Aug 22, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Aug 17, 2024 •
edited by shekhirin
Loading

Adds tests for the CanonChainTracker implementation of the BlockchainProvider2 and closes #10352.

@greged93 greged93 marked this pull request as draft August 17, 2024 21:42
@shekhirin
Copy link
Collaborator

Is this ready for review? We merged a bunch of other tests and helper functions into main, can you please merge it into your branch?

@shekhirin shekhirin added A-db Related to the database C-test A change that impacts how or what we test A-engine Related to the engine implementation labels Aug 20, 2024
@greged93
Copy link
Contributor Author

Was waiting for the helper to get merged, will rebase

@greged93 greged93 force-pushed the test/CanonChainTracker branch from e1e4c74 to 46cf745 Compare August 20, 2024 17:28
@greged93 greged93 marked this pull request as ready for review August 20, 2024 17:28
@greged93
Copy link
Contributor Author

@shekhirin should be ready now

@greged93 greged93 force-pushed the test/CanonChainTracker branch from 46cf745 to 8d10ff8 Compare August 21, 2024 16:31
@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

smol conflict

@greged93 greged93 force-pushed the test/CanonChainTracker branch from 8d10ff8 to 9f18495 Compare August 22, 2024 07:17
shekhirin
shekhirin approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shekhirin shekhirin added this pull request to the merge queue Aug 22, 2024
Merged via the queue into paradigmxyz:main with commit a4c30ea Aug 22, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin approved these changes

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-engine Related to the engine implementation C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test CanonChainTracker implementation of BlockchainProvider2<DB>
3 participants
@greged93 @shekhirin @mattsse