Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: add test_block_body_indices for block_body_indices #10429

Merged
merged 6 commits into from
Aug 26, 2024
Merged

storage: add test_block_body_indices for block_body_indices #10429

merged 6 commits into from
Aug 26, 2024

Conversation

tcoratger
Copy link
Contributor

Related #10338

@shekhirin
Copy link
Collaborator

Blocked by #10356, want to get it in first because it'll cause a bunch of conflicts

@emhane emhane added A-db Related to the database C-test A change that impacts how or what we test A-engine Related to the engine implementation labels Aug 21, 2024
@emhane
Copy link
Member

emhane commented Aug 21, 2024

unblocked @shekhirin

@tcoratger
Copy link
Contributor Author

unblocked @shekhirin
@emhane Just rebased and fixed conflicts

shekhirin
shekhirin previously requested changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use the new helper, otherwise LGTM.

@mattsse mattsse added this pull request to the merge queue Aug 26, 2024
Merged via the queue into paradigmxyz:main with commit e0b994b Aug 26, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekhirin shekhirin shekhirin left review comments

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-engine Related to the engine implementation C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcoratger @shekhirin @emhane @mattsse