Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rpc): avoid redundant tx decoding on witness generation #10474

Merged
merged 1 commit into from
Aug 23, 2024
Merged

perf(rpc): avoid redundant tx decoding on witness generation #10474

merged 1 commit into from
Aug 23, 2024

Conversation

rkrasiuk
Copy link
Member

Description

SealedBlock::raw_transactions encoded block transactions which were immediately decoded afterwards. Call SealedBlockWithSenders::into_transactions_ecrecovered instead.

@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation labels Aug 23, 2024
@rkrasiuk rkrasiuk enabled auto-merge August 23, 2024 04:40
@rkrasiuk rkrasiuk added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit accd051 Aug 23, 2024
35 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/rpc-witness-avoid-redundant-decoding branch August 23, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkrasiuk @mattsse