feat(cli): enable witness invalid block hook by default #10839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
shekhirin
force-pushed
the
alexey/invalid-block-hook-default
branch
from
77368d6 to
d96129f
Compare
shekhirin
requested review from
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mattsse
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #10405
With the witness hook enabled by default, we can have better insight into what caused the state root mismatch when users report it. The witness will be dumped into
DATADIR/invalid_block_hooks/witness/BLOCK_HASH.json, and we can ask users to include it in the issue.