fix(reth): bin/reth missing help msg of segment #10873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found in #10856 (comment)
when building reth without
--workspace
, the output of the binary doesn't have the help message of SEGMENT:but when building with
--workspace
, refreth/.github/workflows/lint.yml
Lines 143 to 149 in 817b152
then it contains the segment info:
Then found the define of StaticFileSegment has an
cfg_attr
reth/crates/static-file/types/src/segment.rs
Lines 24 to 26 in 817b152
So I think we need to implictly import the
reth_static_file_types
crate