chore(reth-provider): use Vec::with_capacity #10912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkysg
requested review from
mattsse,
rakita,
joshieDo,
shekhirin and
Rjected
as code owners
nkysg
force-pushed
the
reth_provider_vec
branch
2 times, most recently
from
609b936 to
9793972
Compare
nkysg
commented
Sep 15, 2024
| for ((main_block_number, header), (_, header_hash), (_, tx)) in | ||
| izip!(block_header_iter.into_iter(), block_header_hashes_iter, block_tx_iter) |
There was a problem hiding this comment.
L694 has used into_iter(), so remove in this place
nkysg
commented
Sep 15, 2024
| for ((main_block_number, header), (_, header_hash), (_, tx)) in | ||
| izip!(block_header_iter.into_iter(), block_header_hashes_iter, block_tx_iter) |
nkysg
force-pushed
the
reth_provider_vec
branch
from
9793972 to
94c1b79
Compare
mattsse
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.