Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): lint for derive Compat #11005

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(lint): lint for derive Compat #11005

merged 2 commits into from
Sep 18, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 18, 2024

Fixes lint for derive Compat

@emhane emhane added the A-ci Related to github workflows or other build and lint tools label Sep 18, 2024
@emhane emhane requested a review from joshieDo as a code owner September 18, 2024 22:24
@emhane emhane added C-bug An unexpected or incorrect behavior A-utils Related to commonly used utilities and removed A-ci Related to github workflows or other build and lint tools labels Sep 18, 2024
@onbjerg onbjerg enabled auto-merge September 18, 2024 22:28
@onbjerg onbjerg disabled auto-merge September 18, 2024 22:42
onbjerg
onbjerg reviewed Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the tests as well since this adds new tokens, it's a bit annoying but it is what it is. otherwise lgtm

@emhane emhane enabled auto-merge September 18, 2024 23:07
@emhane emhane added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit a636408 Sep 18, 2024
35 checks passed
@emhane emhane deleted the emhane/fix-compat-lint branch September 18, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-utils Related to commonly used utilities C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @onbjerg