perf(db): use smallvec for mdbx table names #11291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested review from
rakita,
shekhirin,
onbjerg,
mattsse and
gakonst
as code owners
shekhirin
added
C-perf
shekhirin
approved these changes
Sep 27, 2024
DaniPopes
force-pushed
the
dani/db-new-cstring
branch
from
b18389a to
10fda40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database::newis called on everytx.new_cursor,tx.get,tx.put... (a lot). This function allocates aCStringfor the table name to pass it through FFI to mdbx. Use smallvec to create theCStron the stack to avoid this allocation.