Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve IntegerList API to avoid allocations #11292

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

DaniPopes
Copy link
Member

RoaringBitmap is constructed using iterators, don't force callers to construct IntegerList using slices.

@DaniPopes DaniPopes force-pushed the dani/perf-integerlist branch from 65d5499 to 45f7a77 Compare September 27, 2024 15:11
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, falling clippy

@DaniPopes DaniPopes force-pushed the dani/perf-integerlist branch from d8927a4 to c393e58 Compare September 27, 2024 16:32
@DaniPopes DaniPopes added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit bf18fd9 Sep 27, 2024
36 checks passed
@DaniPopes DaniPopes deleted the dani/perf-integerlist branch September 27, 2024 17:00
@DaniPopes DaniPopes added the C-perf A change motivated by improving speed, memory usage or disk footprint label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants