perf(db): cache ProcessUID::own
in memory
#11302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System::new_with_specifics
is fairly expensive since it will read and parse all of/proc
, on my machine it takes ~350ms.I think caching our own PID is valid since we only use
start_time
.After opening this PR I realized we can filter the parsing step to only parse
/proc/<id>
, and this takes it down to a few microseconds (I can't even see it with samply anymore); I think caching is still worth it just to not deal with any files after parsing it once(This is called at least twice, in
DatabaseEnv::open
andStaticFileProvider::new
)