Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reth primitives traits tx type #11720

Merged
merged 11 commits into from
Oct 30, 2024

Conversation

0xriazaka
Copy link
Contributor

Closes #11531
Define trait reth_primitives_traits::TxType

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions, adding an empty trait seems fine until we finally integrate, where we might need to add some methods

@0xriazaka 0xriazaka requested a review from Rjected October 23, 2024 22:37
@emhane
Copy link
Member

emhane commented Oct 30, 2024

need help with this @0xriazaka ? it's the key pr for making progress on sdk work rn

@0xriazaka
Copy link
Contributor Author

need help with this @0xriazaka ? it's the key pr for making progress on sdk work rn

check the pr

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@Rjected Rjected added C-enhancement New feature or request A-sdk Related to reth's use as a library labels Oct 30, 2024
@Rjected Rjected added this pull request to the merge queue Oct 30, 2024
Merged via the queue into paradigmxyz:main with commit b42b189 Oct 30, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define trait TxType
3 participants