Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eth69): support for ETH69 #12158

Merged
merged 6 commits into from
Oct 30, 2024
Merged

feat(eth69): support for ETH69 #12158

merged 6 commits into from
Oct 30, 2024

Conversation

Abhishekkochar
Copy link
Contributor

fixes #10659

@Abhishekkochar
Copy link
Contributor Author

I have introduced the ETH69 type but not support for removing td from status. This will involve modifying couple of tests. I can proceed with the remanning changes once confirmed. Thanks

cc @mattsse @emhane @Rjected

mattsse
mattsse requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great first step, some suggestions

crates/net/network/src/transactions/mod.rs Outdated
@@ -1669,6 +1669,7 @@ impl PooledTransactionsHashesBuilder {
match version {
EthVersion::Eth66 | EthVersion::Eth67 => Self::Eth66(Default::default()),
EthVersion::Eth68 => Self::Eth68(Default::default()),
EthVersion::Eth69 => todo!(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can treat this the same as 68 here

crates/net/eth-wire-types/src/message.rs Outdated
EthMessage::NewBlockHashes(NewBlockHashes::decode(buf)?)
}
EthMessageID::NewBlock => EthMessage::NewBlock(Box::new(NewBlock::decode(buf)?)),
EthMessageID::NewBlock => {
if version == EthVersion::Eth69 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use is_eth69

@mattsse
Copy link
Collaborator

mattsse commented Oct 29, 2024

I have introduced the ETH69 type but not support for removing td from status.

yeah for this we need an entirely new Status type or make it optional, need to take a look at the spec first

@mattsse mattsse marked this pull request as ready for review October 29, 2024 14:06
@mattsse mattsse added the A-networking Related to networking in general label Oct 29, 2024
@Abhishekkochar
Copy link
Contributor Author

@mattsse failed tests are unrelated to changed code here.

mattsse
mattsse approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

I think next we need to make some changes to Status, let me track that first

@mattsse mattsse added this pull request to the merge queue Oct 30, 2024
@mattsse mattsse mentioned this pull request Oct 30, 2024
Closed
Merged via the queue into paradigmxyz:main with commit ff9a42a Oct 30, 2024
40 checks passed
@Abhishekkochar Abhishekkochar deleted the ak/eth69 branch December 15, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for eth/69 (EIP-7642)
2 participants
@Abhishekkochar @mattsse