chore(sdk): impl SignedTransaction for TransactionSigned
#12187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshieDo
reviewed
Nov 5, 2024
| signature: Signature, | ||
| ) -> Self { | ||
| Self::from_transaction_and_signature(transaction, signature) | ||
| fn from_transaction_and_signature(transaction: Transaction, signature: Signature) -> Self { |
There was a problem hiding this comment.
should we add some version of this with hash? recalculating the hash seems wasteful. i took a peek at the codebase and it seems like we do this even when the type already has an hash . eg
impl TryFrom<WithOtherFields<alloy_rpc_types::Transaction>> for TransactionSigned {or adding a maybe_tx_hash() -> Option<TxHash> to the trait, that can be checked here
There was a problem hiding this comment.
definitely! nice find, think it doesn't fit in scope of this refactor pr though, please open a perf issue for this
klkvr
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12169
Implements
SignedTransactionforTransactionSigned, treatingTransactionSignedas an l1 type only