Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(utils): Util function for headers request #12501

Merged
merged 6 commits into from
Nov 13, 2024
Merged

chore(utils): Util function for headers request #12501

merged 6 commits into from
Nov 13, 2024
+37 −17

Conversation

TheDhejavu
Copy link
Contributor

@TheDhejavu TheDhejavu commented Nov 13, 2024 •
edited
Loading

Resolves: #12495

mattsse
mattsse requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I think I wasn't super clear in the issue.

the issue was only meant to introduce some helper constructors for the headerrequest type,

we can leave all of this code as is, so perhaps easier to close?

@TheDhejavu TheDhejavu force-pushed the util-function--for-headers-request branch from 0ff5594 to 586b55c Compare November 13, 2024 14:37
@TheDhejavu TheDhejavu marked this pull request as ready for review November 13, 2024 14:38
mattsse
mattsse approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, ty!

@mattsse mattsse added this pull request to the merge queue Nov 13, 2024
@mattsse mattsse added the C-enhancement New feature or request label Nov 13, 2024
Merged via the queue into paradigmxyz:main with commit 7a1698c Nov 13, 2024
40 checks passed
@TheDhejavu TheDhejavu deleted the util-function--for-headers-request branch November 13, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add util functions for HeadersRequest
2 participants
@TheDhejavu @mattsse