Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement Compact for OpTxType #12537

Merged
merged 6 commits into from
Nov 15, 2024
Merged

feat: implement Compact for OpTxType #12537

merged 6 commits into from
Nov 15, 2024

Conversation

kamuik16
Copy link
Contributor

Closes #12516

cc @emhane

emhane
emhane requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

@kamuik16
Copy link
Contributor Author

thanks a lot !

done, but not really sure how to solve the CI error.

@kamuik16 kamuik16 requested a review from emhane November 14, 2024 16:38
emhane
emhane requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

@kamuik16 kamuik16 requested a review from emhane November 15, 2024 13:45
emhane
emhane approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane added this pull request to the merge queue Nov 15, 2024
Merged via the queue into paradigmxyz:main with commit ac5976f Nov 15, 2024
41 checks passed
@kamuik16 kamuik16 deleted the kamui branch November 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Compact for OpTxType
2 participants
@kamuik16 @emhane