Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move gas_spent_by_transactions to traits #12541

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 14, 2024

moves the helper functions and makes it take TxTrait as input

@mattsse mattsse requested review from emhane and klkvr and removed request for Rjected and joshieDo November 14, 2024 14:51
@mattsse mattsse added the A-sdk Related to reth's use as a library label Nov 14, 2024
@mattsse mattsse enabled auto-merge November 14, 2024 14:52
@mattsse mattsse force-pushed the matt/move-gas-spent-by-txs-to-primitives-crates branch from 3795bdd to 154ec28 Compare November 14, 2024 14:52
@mattsse mattsse added this pull request to the merge queue Nov 14, 2024
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

Merged via the queue into main with commit 28a5b63 Nov 14, 2024
40 checks passed
@mattsse mattsse deleted the matt/move-gas-spent-by-txs-to-primitives-crates branch November 14, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants