Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct timestamp for op receipt #12716

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Nov 20, 2024

closes #12177

removes the default derive which was the footgun that caused this bug, we need the timestamp to compute the fee fields but never set it.

@github-actions github-actions bot added the C-bug An unexpected or incorrect behavior label Nov 20, 2024
@mattsse mattsse added the A-op-reth Related to Optimism and op-reth label Nov 20, 2024
@mattsse mattsse added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 8df9045 Nov 20, 2024
41 checks passed
@mattsse mattsse deleted the matt/fix-op-l1-fee-fields branch November 20, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eth_getBlockReceipts returning different fee for a tx compared to basescan
2 participants