Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(rpc-tx-helpers): simplify clones #12800

Merged
merged 1 commit into from
Nov 23, 2024
Merged

perf(rpc-tx-helpers): simplify clones #12800

merged 1 commit into from
Nov 23, 2024

Conversation

hai-rise
Copy link
Contributor

@hai-rise hai-rise commented Nov 23, 2024 •
edited
Loading

Simplify more clones as I study the pool transaction life cycle 🙏.

mattsse
mattsse approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Nov 23, 2024
@mattsse mattsse added the C-debt A clean up/refactor of existing code label Nov 23, 2024
Merged via the queue into paradigmxyz:main with commit 047bf86 Nov 23, 2024
41 checks passed
@hai-rise hai-rise deleted the simplify-clones branch November 23, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hai-rise @mattsse