feat: add Block AT to BlockReader
#12837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Nov 25, 2024
klkvr
force-pushed
the
klkvr/block-reader-at
branch
from
8c247fa to
bad1136
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12836
This PR adds
BlockAT toBlockReadertrait making it output dependent on provider primitive types.There's a limitation of
auto_implcrate due to which I've had to implementBlockReaderfor&TandArc<T>manuallyBesides that, most of the changes for now are adding block generics and locking them to
reth_primitives::Blockwhere needed.With this PR, database providers are completely abstract over transaction and block body, and for higher-level providers we are blocked on tree types