Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: profile TransactionsManager::poll hash fetching #12975

Merged
merged 6 commits into from
Dec 6, 2024
Merged

perf: profile TransactionsManager::poll hash fetching #12975

merged 6 commits into from
Dec 6, 2024

Conversation

Elvis339
Copy link
Contributor

Issue: #12842

This PR attempts to profile TransactionsManager::poll hash fetching.

@Elvis339
Copy link
Contributor Author

Test case added for debugging purposes, I will delete it later.

mattsse
mattsse requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like this a lot.

testing this one specific code path is a bit challenging, I'll also try this out.

featurewise, I consider this PR completed once it compiles, because the next part is now just debugging work.

@mattsse mattsse marked this pull request as ready for review November 28, 2024 16:35
@Elvis339 Elvis339 requested a review from mattsse November 28, 2024 17:14
@mattsse mattsse added C-test A change that impacts how or what we test A-networking Related to networking in general labels Nov 28, 2024
@Elvis339 Elvis339 requested a review from mattsse November 29, 2024 11:21
@Elvis339
Copy link
Contributor Author

Elvis339 commented Dec 4, 2024 •
edited
Loading

Just bumping this up for visibility, should this be merged or should I provide more data on this? cc @mattsse

@mattsse
Copy link
Collaborator

mattsse commented Dec 6, 2024 •
edited
Loading

nope this is good, was just holding off in case we introduced some conflicts with some recent changes,

looks like we're good, ty

@mattsse mattsse enabled auto-merge December 6, 2024 09:37
@mattsse mattsse force-pushed the profile-tx-hash-fetching branch from d48d6e7 to 50d4559 Compare December 6, 2024 09:44
@mattsse mattsse added this pull request to the merge queue Dec 6, 2024
Merged via the queue into paradigmxyz:main with commit d3e09c8 Dec 6, 2024
41 checks passed
@Elvis339 Elvis339 deleted the profile-tx-hash-fetching branch December 6, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@emhane emhane Awaiting requested review from emhane

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general C-test A change that impacts how or what we test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elvis339 @mattsse