refactor(sdk): complete generic impl for PersistenceService over N::Primitives
#13044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lean-apple
changed the title
PersistenceService over N::Primitives
lean-apple
requested review from
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
Rjected
previously requested changes
Dec 3, 2024
| // create the initial channels | ||
| let (db_service_tx, db_service_rx) = std::sync::mpsc::channel(); | ||
|
|
||
| // construct persistence handle | ||
| let persistence_handle = Self::new(db_service_tx); | ||
| let persistence_handle = PersistenceHandle::<N::Primitives>::new(db_service_tx); |
There was a problem hiding this comment.
If we do just PersistenceHandle::new here, does it still compile?
mattsse
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12941.