feat(executor): call hook with state changes after post block balance increments #13050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
mattsse,
Rjected,
emhane and
rakita
as code owners
rkrasiuk
requested changes
Dec 2, 2024
crates/evm/src/execute.rs
Outdated
Comment on lines
521
to
523
| let transition_account = account | ||
| .increment_balance(balance_inc) | ||
| .ok_or(BlockValidationError::IncrementBalanceFailed)?; |
There was a problem hiding this comment.
balance was already incremented prior to this call. this does it 2nd time
rkrasiuk
requested changes
Dec 2, 2024
rkrasiuk
reviewed
Dec 2, 2024
rkrasiuk
approved these changes
Dec 2, 2024
|
|
||
| balance_increments | ||
| .iter() | ||
| .filter(|(_, &balance)| balance != 0) |
There was a problem hiding this comment.
this shouldn't be possible but fine leaving as is for now
shekhirin
approved these changes
Dec 2, 2024
shekhirin
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13024
Added function to create an
EvmStatefrom the post-block balance increments. ThisEvmStateis used to call the state hook in the Ethereum and Optimism executors.