Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename HighestStaticFiles::min #13235

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Dec 9, 2024

My IDE was having trouble distinguishing this from the min method from Ord for some reason, so I just changed the name

@Rjected Rjected added the A-static-files Related to static files label Dec 9, 2024
Copy link
Collaborator

@shekhirin shekhirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE (i use neovim) had the same issue, LGTM

@shekhirin shekhirin enabled auto-merge December 9, 2024 17:10
@shekhirin shekhirin added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit b5bbb8d Dec 9, 2024
43 checks passed
@shekhirin shekhirin deleted the dan/min-static-files-name branch December 9, 2024 17:29
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-static-files Related to static files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants