Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(trie): use entry API in sparse trie #13240

Merged
merged 4 commits into from
Dec 9, 2024
Merged

perf(trie): use entry API in sparse trie #13240

merged 4 commits into from
Dec 9, 2024

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Dec 9, 2024 •
edited
Loading

Uses hashmap entry API in reveal_node to avoid looking up the entry twice when inserting a new node.

@shekhirin shekhirin added C-perf A change motivated by improving speed, memory usage or disk footprint A-trie Related to Merkle Patricia Trie implementation labels Dec 9, 2024
@shekhirin shekhirin marked this pull request as ready for review December 9, 2024 18:51
@shekhirin shekhirin marked this pull request as draft December 9, 2024 18:52
@shekhirin shekhirin marked this pull request as ready for review December 9, 2024 18:59
@shekhirin shekhirin force-pushed the alexey/sparse-trie-entry branch from 38cd76c to 0056ed1 Compare December 9, 2024 18:59
rkrasiuk
rkrasiuk requested changes Dec 9, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gud otherwise

@shekhirin shekhirin requested a review from rkrasiuk December 9, 2024 19:26
@shekhirin shekhirin enabled auto-merge December 9, 2024 19:29
@shekhirin shekhirin added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit f4ae439 Dec 9, 2024
42 checks passed
@shekhirin shekhirin deleted the alexey/sparse-trie-entry branch December 9, 2024 19:54
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@shekhirin @lean-apple
perf(trie): use entry API in sparse trie (paradigmxyz#13240)
f3289d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @rkrasiuk