feat(rpc): relax VaidationApi
and EngineApi
#13241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13232
Relaxes bounds for
ValidationApi
andEngineApi
, migrating all of the RPC setup off the concrete primitives.Changes:
Block
AT andensure_well_formed_payload
method are extracted fromEngineValidator
into a separatePayloadValidator
which can be used to validateExecutionPayload
s without the need to know entireEngineTypes
Arc<dyn PayloadValidator>
is stored on rpc builder and rpc registry, and passed toValidationApi
to abastract theExecutionPayload
->Block
conversion. I didn't make it a generic because this would require adding an additional generic toRpcRegistry
and all types that hold it including user-facingRpcHandle
reth/crates/node/builder/src/rpc.rs
Lines 192 to 206 in 8f98b0f
A one way we could consider simplifying this is require users to implement engine validation traits directly on
Consensus
. This feels semantically right and should also allow make it easier to support nodes without engine