Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fromstr impl for miner variant #13289

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: fromstr impl for miner variant #13289

merged 1 commit into from
Dec 11, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 11, 2024

No description provided.

@mattsse mattsse changed the title fix: fromstr impl fix: fromstr impl for miner variant Dec 11, 2024
@mattsse mattsse added the A-cli Related to the reth CLI label Dec 11, 2024
fgimenez
fgimenez approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattsse mattsse added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit d345ffc Dec 11, 2024
43 checks passed
@mattsse mattsse deleted the matt/fix-fromstr-impl branch December 11, 2024 09:07
mattsse added a commit that referenced this pull request Dec 11, 2024
@mattsse
fix: fromstr impl for miner variant (#13289)
3ea2522
lean-apple pushed a commit to lean-apple/reth that referenced this pull request Dec 12, 2024
@mattsse @lean-apple
fix: fromstr impl for miner variant (paradigmxyz#13289)
59c2a1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgimenez fgimenez fgimenez approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
A-cli Related to the reth CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @fgimenez