Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): desired block gas limit #13351

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Conversation

rkrasiuk
Copy link
Member

Description

Closes #13128

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior A-block-building Related to block building labels Dec 12, 2024
@github-actions github-actions bot added A-cli Related to the reth CLI C-enhancement New feature or request labels Dec 12, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits

@rkrasiuk rkrasiuk requested a review from mattsse December 12, 2024 14:35
Comment on lines 40 to 41
/// Calculate the gas limit for the next block based on parent and desired gas limits.
pub fn calculate_block_gas_limit(parent_gas_limit: u64, desired_gas_limit: u64) -> u64 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reference for this, I'd prefer if we could link this

@rkrasiuk rkrasiuk enabled auto-merge December 12, 2024 15:06
@rkrasiuk rkrasiuk added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e957772 Dec 12, 2024
42 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/desired-block-gas-limit branch December 12, 2024 16:44
emhane pushed a commit to ethereum-optimism/op-reth that referenced this pull request Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use --builder.gaslimit cli argument for payload building
3 participants