refactor: integrate BuiltPayload::Primitives #13484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
Rjected,
fgimenez,
onbjerg,
rkrasiuk and
gakonst
as code owners
klkvr
added
A-consensus
mattsse
approved these changes
Dec 23, 2024
| @@ -24,7 +24,6 @@ reth-payload-builder-primitives.workspace = true | |||
| reth-payload-primitives.workspace = true | |||
| reth-provider.workspace = true | |||
| reth-prune.workspace = true | |||
| reth-rpc-types-compat.workspace = true | |||
Comment on lines
+84
to
+89
| /// Converts a [`BuiltPayload`] into an [`ExecutionPayload`] and [`ExecutionPayloadSidecar`]. | ||
| fn block_to_payload( | ||
| block: SealedBlockFor< | ||
| <<Self::BuiltPayload as BuiltPayload>::Primitives as NodePrimitives>::Block, | ||
| >, | ||
| ) -> (ExecutionPayload, ExecutionPayloadSidecar); |
There was a problem hiding this comment.
this makes sense, we can likely do something about these casts
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates
NodePrimitivestoBuiltPayload. It doesn't make a lot of sense as a generic because every built payload is required to holdExecutedBlockwhich is generic over primitives, thus the type will always know the primitives type.Additionally I've extracted block -> ExecutionPayload conversion to
EngineTypes. For now both implementations just call the same fn as we were using for this earlier