Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: net/nat retain https scheme for external #13507

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

tiendn
Copy link
Contributor

@tiendn tiendn commented Dec 23, 2024

Keep HTTPS scheme for security and reliability (potentially intercept and modify the response, providing you with incorrect IP information):

  • Prevents man-in-the-middle attacks
  • Ensures data integrity
  • Follows modern security best practices
  • Maintains compatibility with services that enforce HTTPS

Copy link

codspeed-hq bot commented Dec 27, 2024

CodSpeed Performance Report

Merging #13507 will not alter performance

Comparing tiendn:fix/retain-https-external-link (36140c4) with main (5a21bda)

Summary

✅ 77 untouched benchmarks

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase i think, otherwise lgtm

@tiendn
Copy link
Contributor Author

tiendn commented Dec 28, 2024

I've updated latest code, please check @Rjected

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! this looks good to me

@Rjected Rjected added this pull request to the merge queue Dec 30, 2024
Merged via the queue into paradigmxyz:main with commit a6325c4 Dec 30, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants