Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable default std serde_json feature #13513

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 23, 2024

towards #13041

#[cfg(not(any(feature = "std", feature = "alloc")))]
compile_error! {
    "serde_json requires that either `std` (default) or `alloc` feature is enabled"
}

serde-json supports no-std but requires at least alloc

@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Dec 23, 2024
@mattsse mattsse requested a review from onbjerg as a code owner December 23, 2024 07:49
Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13513 will not alter performance

Comparing fix/disable-default-std-for-serde-json (4e4a708) with main (6e14010)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/disable-default-std-for-serde-json Change
⁉️ range lookup` 611 µs N/A N/A
⁉️ any lookup` 19.8 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
🆕 range lookup` N/A 608.3 µs N/A
🆕 any lookup` N/A 19.3 ms N/A
🆕 `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

@mattsse mattsse merged commit 517e5db into main Dec 23, 2024
42 of 43 checks passed
@mattsse mattsse deleted the fix/disable-default-std-for-serde-json branch December 23, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant