feat: generic data primitives block builder test framework #13522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoank101
requested review from
rakita,
joshieDo,
shekhirin,
rkrasiuk,
mattsse,
Rjected and
fgimenez
as code owners
CodSpeed Performance ReportMerging #13522 will not alter performanceComparing Summary
|
|
hi @emhane please help me review this PR |
mattsse
requested changes
Dec 25, 2024
crates/engine/tree/src/tree/mod.rs
Outdated
| @@ -3417,7 +3420,8 @@ mod tests { | |||
| async fn test_tree_state_remove_before_finalized() { | |||
| let start_num_hash = BlockNumHash::default(); | |||
| let mut tree_state = TreeState::new(start_num_hash); | |||
| let blocks: Vec<_> = TestBlockBuilder::default().get_executed_blocks(1..6).collect(); | |||
| let blocks: Vec<_> = | |||
| TestBlockBuilder::<EthPrimitives>::default().get_executed_blocks(1..6).collect(); | |||
There was a problem hiding this comment.
I'd like to introduce a TestBlockBuilder::eth function for this
There was a problem hiding this comment.
thank, i just updated
mattsse
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13239